Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't resolve underscore #11

Closed
brandonkal opened this issue Dec 21, 2018 · 1 comment
Closed

Can't resolve underscore #11

brandonkal opened this issue Dec 21, 2018 · 1 comment

Comments

@brandonkal
Copy link

videojs-airplay/src/js/enableAirPlay.js

Line 8 in c1b783a

_ = require('underscore');

You are requiring underscore but it is not listed as a dependency in your package.json. Is this plugin still maintained? Thanks.
@jthomerson
Copy link
Member

😕 @yokuze ? Not sure how we missed that. I guess because everywhere we're using it, _ is available.

yokuze added a commit to yokuze/videojs-airplay that referenced this issue Dec 24, 2018
@yokuze
Fixes silvermine#11 Add dependency on underscore
45d38a1
yokuze added a commit to yokuze/videojs-airplay that referenced this issue Dec 24, 2018
@yokuze
Fixes silvermine#11 Add dependency on underscore
095438b
jthomerson added a commit that referenced this issue Dec 25, 2018
@jthomerson
Merge pull request #13 from yokuze/add_missing_underscore_dependency_11
4dfcb29 
Fixes #11 Add dependency on underscore
@jthomerson jthomerson mentioned this issue Oct 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jthomerson @brandonkal