Skip to content

Commit

Permalink
Merge pull request #19 from pbredenberg/chore-upgrade-node
Browse files Browse the repository at this point in the history
Upgrade Node and add standards enforcement
  • Loading branch information
onebytegone authored May 22, 2020
2 parents 88d6477 + 82885e4 commit 793b516
Show file tree
Hide file tree
Showing 8 changed files with 3,157 additions and 419 deletions.
3 changes: 3 additions & 0 deletions .markdownlint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"extends": "./node_modules/@silvermine/standardization/.markdownlint.json"
}
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
8.10.0
12.14.0
11 changes: 9 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,18 @@ language: node_js
node_js:
- "node" # Latest node version
- "lts/*" # Latest LTS version
- "12"
- "10"
- "8"
- "8.10"

before_install: if [[ `npm -v` != 6* ]]; then npm i -g [email protected]; fi
before_install: npm i -g [email protected]

script:
- node --version
- npm --version
- commitlint-travis
- grunt standards
- npm test

# For code coverage:
after_success:
Expand Down
15 changes: 14 additions & 1 deletion Gruntfile.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
'use strict';

var markdownlint = require('markdownlint');

module.exports = function(grunt) {

var config;
Expand All @@ -18,11 +20,22 @@ module.exports = function(grunt) {
target: config.js.all,
},

markdownlint: {
all: {
src: [ 'README.md' ],
options: {
// eslint-disable-next-line no-sync
config: markdownlint.readConfigSync('.markdownlint.json'),
},
},
},

});

grunt.loadNpmTasks('grunt-eslint');
grunt.loadNpmTasks('grunt-markdownlint');

grunt.registerTask('standards', [ 'eslint' ]);
grunt.registerTask('standards', [ 'eslint', 'markdownlint' ]);
grunt.registerTask('default', [ 'standards' ]);

};
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ NOTE: at this time, it is assumed that the topic is in the same account and
region as the Lambda function itself. That can be changed in the future if
needed - feel free to open an issue, and preferably submit a pull request.

```
```yaml
functions:
doSomething:
name: ${self:service}-${self:provider.stage}-doSomething
Expand Down
5 changes: 5 additions & 0 deletions commitlint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
'use strict';

module.exports = {
extends: [ '@silvermine/standardization/commitlint.js' ],
};
Loading

0 comments on commit 793b516

Please sign in to comment.