Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Promises in Middleware / Handlers #30

Closed
jthomerson opened this issue Mar 9, 2019 · 2 comments
Closed

Support Promises in Middleware / Handlers #30

jthomerson opened this issue Mar 9, 2019 · 2 comments
Assignees
@yokuze @onebytegone

Comments

@jthomerson
Copy link
Member

Since our org typically prefers promises over callbacks, I was excited to see that 5.x versions of Express will support promises. Please evaluate what they support and whether we can support it while still supporting the callback variant as well.

References:
@jthomerson
Copy link
Member Author

Assigned to @yokuze and @onebytegone. You guys can work out who has better availability to look into this.

onebytegone added a commit that referenced this issue Mar 15, 2019
@onebytegone
feat: Add support for promises in handlers (#30)
9117300
onebytegone added a commit that referenced this issue Mar 15, 2019
@onebytegone
feat: Add support for promises in handlers (#30)
eb1c65f
onebytegone added a commit that referenced this issue Mar 19, 2019
@onebytegone
feat: Add support for promises in handlers (#30)
55860ab
onebytegone added a commit that referenced this issue Mar 20, 2019
@onebytegone
feat: Add support for promises in handlers (#30)
2af8921
onebytegone added a commit that referenced this issue Mar 20, 2019
@onebytegone
feat: Add support for promises in handlers (#30)
45508cc
jthomerson pushed a commit that referenced this issue Mar 21, 2019
@onebytegone @jthomerson
feat: Add support for promises in handlers (#30)
49f500c
jthomerson added a commit that referenced this issue Mar 21, 2019
@jthomerson
Merge pull request #32 from silvermine/promise_support
17426c1 
feat: Add support for promises in handlers (#30)
@onebytegone
Copy link
Contributor

Closed by #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yokuze yokuze

@onebytegone onebytegone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jthomerson @yokuze @onebytegone