Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider router.route method #19

Open
jthomerson opened this issue Feb 26, 2019 · 1 comment
Open

Consider router.route method #19

jthomerson opened this issue Feb 26, 2019 · 1 comment
Assignees
Milestone

Comments

@jthomerson
Copy link
Member

See

// TODO: do we need `router.route`?
// https://expressjs.com/en/guide/routing.html#app-route
// https://expressjs.com/en/4x/api.html#router.route
// If we do add it, we need to set the case-sensitivity of the sub-router it creates
// using the case-sensitivity setting of this router.

@jthomerson jthomerson added this to the 1.0.0 milestone Feb 26, 2019
@jthomerson jthomerson self-assigned this Feb 26, 2019
@yokuze
Copy link
Contributor

yokuze commented Feb 28, 2019

This is a note to self that if we implement this, and we choose to have route create a subrouter from the router it's called from, to be sure to make the subrouter inherit its settings from its parent.

yokuze added a commit to yokuze/lambda-express that referenced this issue Mar 18, 2019
yokuze added a commit to yokuze/lambda-express that referenced this issue Mar 18, 2019
yokuze added a commit to yokuze/lambda-express that referenced this issue Mar 18, 2019
yokuze added a commit to yokuze/lambda-express that referenced this issue Mar 21, 2019
jthomerson pushed a commit to yokuze/lambda-express that referenced this issue Mar 24, 2019
jthomerson added a commit that referenced this issue Mar 24, 2019
feat: Add Router `route` method (#19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants