Remove deprecated forked indent rule #41
Comments
jimjenkins5
added a commit
to jimjenkins5/eslint-plugin-silvermine
that referenced
this issue
Dec 27, 2019
The reason for forking the indent rule was to allow us to line up variable declarations. The original indent rule only allowed doing this if you used 2 or 4 space indent. The new eslint rule has a setting to require variable declarations to line up, so this rule is no longer needed. In fact, our own config now uses the default rule.
jimjenkins5
added a commit
to jimjenkins5/eslint-plugin-silvermine
that referenced
this issue
Jan 10, 2020
The reason for forking the indent rule was to allow us to line up variable declarations. The original indent rule only allowed doing this if you used 2 or 4 space indent. The new eslint rule has a setting to require variable declarations to line up, so this rule is no longer needed. In fact, our own config now uses the default rule.
jthomerson
pushed a commit
that referenced
this issue
Jan 22, 2020
The reason for forking the indent rule was to allow us to line up variable declarations. The original indent rule only allowed doing this if you used 2 or 4 space indent. The new eslint rule has a setting to require variable declarations to line up, so this rule is no longer needed. In fact, our own config now uses the default rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The indent rule was originally forked to provide support for lining up variable declarations. The new indent rule now has a setting to support this. In fact, silvermine's own config no longer uses this forked rule and uses the default rule instead.
We should remove this unnecessary rule now, before pushing a breaking change version, to reduce maintenance overhead.
The text was updated successfully, but these errors were encountered: