Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies to fix vulnerabilities #31

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jimjenkins5
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented May 13, 2021

Coverage Status

Coverage increased (+2.5%) to 72.519% when pulling aca54d2 on jimjenkins5:jimjenkins5/update-deps into 72fc605 on silvermine:master.

@jimjenkins5 jimjenkins5 force-pushed the jimjenkins5/update-deps branch from 869a8e6 to 62647c4 Compare May 13, 2021 15:22
@jimjenkins5
Copy link
Contributor Author

Back to you @jthomerson

@jimjenkins5 jimjenkins5 force-pushed the jimjenkins5/update-deps branch from 62647c4 to 0a4deaa Compare May 13, 2021 19:12
Copy link
Contributor

@yokuze yokuze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimjenkins5 a couple of changes needed.

"aws-sdk": "2.354.0",
"check-node-version": "4.0.3",
"coveralls": "3.0.2",
"eslint": "6.8.0",
"expect.js": "0.3.1",
"grunt": "1.0.3",
"grunt": "^1.4.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a ^ slipped in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimjenkins5 this doesn't seem to have been fixed?

@@ -40,6 +40,12 @@ module.exports = Class.extend({

lastSeconds = lastPoint[0];

// Underscore will now make descending ranges if provided with a negative stop. TO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TO -> To

@jimjenkins5 jimjenkins5 force-pushed the jimjenkins5/update-deps branch from 0a4deaa to aca54d2 Compare May 24, 2021 14:09
@jimjenkins5
Copy link
Contributor Author

Back to you @yokuze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants