FIX Remove second paginator. The original is invisible, but will be fixed in the framework. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like a framework bug preventing these builds from passing. The tests all run fine locally with the same PHP/PHPUnit/composer installation. Logged here: silverstripe/silverstripe-framework#6574 |
…ixed in the framework.
robbieaverill
force-pushed
the
bugfix/remove-double-paginator
branch
from
69aea38 to
992453a
Compare
|
Regarding the tests failing: The package has been modified to support PHP 5.5 and use PHPUnit 4.8, so this shouldn't be a problem any more. |
zanderwar
approved these changes
Jan 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already a Paginator in the default ModelAdmin GridField configuration, it is just not visible on the screen at the moment. This will be fixed in silverstripe/silverstripe-framework#6545, but we don't need a second one added since it breaks the page sizes, etc.