move delay to the inherited class

silverchris · Aug 14, 2022 · a7085fd · a7085fd
1 parent d2a56e8
commit a7085fd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/include/Platforms/Mazda/Managers/GPSManager.hpp b/include/Platforms/Mazda/Managers/GPSManager.hpp
@@ -27,6 +27,7 @@ class GPSManager: public IGPSManager{
 
   int errorCount;
   std::time_t lastError;
+  const int delay = 1000;
 
   void update_position(const asio::error_code &error);
 

diff --git a/include/autoapp/Managers/IGPSManager.hpp b/include/autoapp/Managers/IGPSManager.hpp
@@ -12,8 +12,6 @@ class IGPSManager: public IManager{
  private:
   std::vector<locationCallback> locationCallbacks;
 
- protected:
-  int delay = 1000;
  public:
   IGPSManager() = default;
   ~IGPSManager() override = default;
@@ -22,7 +20,7 @@ class IGPSManager: public IManager{
     locationCallbacks.emplace_back(callback);
   };
 
-  void updateLocation(aasdk::proto::data::GPSLocation locationData) {
+  void updateLocation(const aasdk::proto::data::GPSLocation& locationData) {
     for (auto &callback : locationCallbacks) {
       callback(locationData);
     }