Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hidden pages #962

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Add hidden pages #962

merged 1 commit into from
Jul 19, 2024

Conversation

Maarrk
Copy link
Contributor

@Maarrk Maarrk commented Jul 19, 2024

Originally proposed in Soft delete notes - Ideas - SilverBullet Community thread.

I love how PR is documented in the website/ every time

@zefhemel
Copy link
Collaborator

I'm up for the all page picker. But for the #hidden thing I'd suggest a different solution now that we have page decorations. Namely... how about we make this a page decoration instead?

pageDecorations:
- where: "tags = 'hidden'"
  hide: true

Now naming is hard, so maybe something more verbose like hideInPicker would be better.

This way we don't need to hard code another tag.

Implementation wise this shouldn't be very hard. The pageDecorations attribute is available in the picker on any PageMeta.

@Maarrk
Copy link
Contributor Author

Maarrk commented Jul 19, 2024

I like that it's opt in and has a configurable query, so the name isn't that important. Will update

@Maarrk Maarrk force-pushed the pr-hidden-pages branch from 00fb66e to f00c4f5 Compare July 19, 2024 05:41
@Maarrk Maarrk force-pushed the pr-hidden-pages branch from f00c4f5 to 4c162da Compare July 19, 2024 05:43
@zefhemel
Copy link
Collaborator

Nice

@zefhemel zefhemel merged commit 75cd4b1 into silverbulletmd:main Jul 19, 2024
1 check passed
@Maarrk Maarrk deleted the pr-hidden-pages branch July 28, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants