Fix space on end of page name creates two pages, one shadowed #615 #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zefhemel
requested changes
Mar 18, 2024
server/http_server.ts
Outdated
| @@ -469,6 +470,7 @@ export class HttpServer { | |||
| const req = c.req; | |||
| const name = req.param("path")!; | |||
| const spaceServer = await this.ensureSpaceServer(req); | |||
| const mdExt = ".md"; | |||
There was a problem hiding this comment.
If you introduce constants like this, I'd prefer them at the top level (top of the file, next to authenticationExpirySeconds) for instance.
|
Sorry for the delay, this looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #615.
Proposed solution
Other
If you want me to create tests, I would like to know if there already exists files places I can put them in.