fix: Update schema to detect duplicates #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the schema as suggested in silnrsi#17 to detect duplicates in tags. It also adds a unit tests to detect duplicates that appear in multiple entries, as suggested in silnrsi#16. This change does not update the data and thus will cause failing tests.
|
Could you remove the need for unique items in latnnames, as described in #17 and the docs. Also I have just added an identical test to the tests (in test_supplemental.py) so that's probably not needed. But thank you for creating a PR and working it through. |
mhosken
reviewed
May 7, 2024
source/langtags_schema.json
Outdated
| }, | ||
| "latnnames": { | ||
| "type": "array", | ||
| "items": { "type": "string" } | ||
| "items": { "type": "string" }, | ||
| "uniqueItems": true |
There was a problem hiding this comment.
This need not be unique. The key is that each entry aligns with a corresponding entry in the localnames array.
latnnames don't have to be unique (see silnrsi#17).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the schema as suggested in #17 to detect duplicates in tags. It also adds a unit tests to detect duplicates that appear in multiple entries, as suggested in #16.
This change does not update the data and thus will cause failing tests.