-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naive implementation in plugin system #40
Comments
Terminfo? Wouldn't that give information about terminal? |
Correct, I think I meant the 'file' command, or maybe https://en.cppreference.com/w/cpp/filesystem/file_type or similar |
Which file is this function in? |
Right, sorry. I was referring to the Linux file command 😄 I'm not sure if it is available on Windows though - and I'm also not sure which library it is part of 🤔 |
I meant, which file is |
It's in the |
Maybe the check for |
So, just remove
I might also downgrade the warning log to an info level, just so you dont get weird warnings about being unable to load non-plugin files. |
You may keep it at debug level actually, if a plugin is loaded, then a info level log would make sense. |
The function
bool is_dynamic_library(const std::string& filename)
implementation is quite naïve in the sense that it just checks if the filename contains dylib/so/dll.This means that a file named
foo.so.txt
is considered a dynamic library and is the program attempts to load it as a plug-in.A real solution would be to use
terminfo
to inspect what the given file is.The text was updated successfully, but these errors were encountered: