Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Security Updates #2878

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Dependency Security Updates #2878

merged 4 commits into from
Dec 2, 2024

Conversation

pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Dec 2, 2024

This PR updates some package dependencies that contain known vulnerabilities:

I have updated these to the minimum fix versions to reduce incompatibilities.

  • NPOI 2.7.1 to 2.7.2
  • MailKit 4.7.0 to 4.8.0
  • Update dependencies of dependencies that dotnet reports as vulnerable:
    • Microsoft.Windows.Compatibility from 6.0.0 to 6.0.6
    • System.Data.SqlClient from 4.8.3 to 4.8.6
    • System.IO.Packaging 6.0.0 to 6.0.1
    • System.Text.Json 7.0.3 to 8.0.5
    • System.Text.RegularExpressions 4.3.0 to 4.3.1
  • Move FileSystemServiceTests to SIL.XForge.Scripture .Tests so that ParatextData is no longer a dependency of SIL.XForge.Tests.

Not Fixed:

I also updated test dependencies as these are low risk.


This change is Reviewable

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.18%. Comparing base (0a643ce) to head (0ff03e1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2878   +/-   ##
=======================================
  Coverage   79.18%   79.18%           
=======================================
  Files         533      533           
  Lines       30965    30965           
  Branches     5054     5049    -5     
=======================================
+ Hits        24520    24521    +1     
  Misses       5659     5659           
+ Partials      786      785    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Nateowami Nateowami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

Copy link
Collaborator

@Nateowami Nateowami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@Nateowami Nateowami merged commit 661951c into master Dec 2, 2024
13 checks passed
@Nateowami Nateowami deleted the fix/security-updates branch December 2, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants