-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SF-3076 Simplify guest role sharing settings #2858
Open
pmachapman
wants to merge
14
commits into
master
Choose a base branch
from
fix/SF-3076
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,814
−907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/RealtimeServer/scriptureforge/services/sf-project-migrations.spec.ts
Fixed
Show fixed
Hide fixed
src/RealtimeServer/scriptureforge/services/sf-project-migrations.spec.ts
Fixed
Show fixed
Hide fixed
src/RealtimeServer/scriptureforge/services/sf-project-migrations.spec.ts
Fixed
Show fixed
Hide fixed
src/RealtimeServer/scriptureforge/services/sf-project-migrations.spec.ts
Fixed
Show fixed
Hide fixed
src/RealtimeServer/scriptureforge/services/sf-project-migrations.spec.ts
Fixed
Show fixed
Hide fixed
pmachapman
force-pushed
the
fix/SF-3076
branch
from
November 18, 2024 22:41
db21685
to
9ba6a3c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2858 +/- ##
==========================================
+ Coverage 79.19% 79.62% +0.43%
==========================================
Files 533 535 +2
Lines 30962 31063 +101
Branches 5052 5063 +11
==========================================
+ Hits 24520 24735 +215
+ Misses 5668 5556 -112
+ Partials 774 772 -2 ☔ View full report in Codecov by Sentry. |
pmachapman
force-pushed
the
fix/SF-3076
branch
from
November 18, 2024 23:02
9ba6a3c
to
e6fae7a
Compare
pmachapman
force-pushed
the
fix/SF-3076
branch
2 times, most recently
from
November 25, 2024 21:04
a00bf25
to
6add968
Compare
pmachapman
force-pushed
the
fix/SF-3076
branch
2 times, most recently
from
November 26, 2024 23:38
6065844
to
36f65f3
Compare
pmachapman
force-pushed
the
fix/SF-3076
branch
from
November 26, 2024 23:54
36f65f3
to
da5c791
Compare
pmachapman
changed the title
WIP: SF-3076 Simplify guest role sharing settings
SF-3076 Simplify guest role sharing settings
Nov 27, 2024
pmachapman
added
the
will require testing
PR should not be merged until testers confirm testing is complete
label
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the sharing functionality to be configured via a simplified interface in Settings.
To achieve this, the following modifications were made to the Scripture Forge codebase:
rolePermissions
property insf_project
(similar touserPermissions
but per role).rightsByRole.json
which is loaded into TypeScript (in the RealtimeServer and Frontend) and C# (dotnet backend).SFProjectRole
andOperation
in C# to allow permissions to be strongly typed.ShareDialogComponent
andShareControlComponent
viaShareBaseComponent
.mongodb/Migrations/
These changes have made this PR considerably larger than originally envisaged, but the goal is a simplification and unification of permission calculations which should make future PRs with permissions simpler.
Notes
mongodb/Migrations/20241127-AddCreatedByRoleToShareKeys.mongodb
Design Mock Up
This change is