Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SF-3028 Add final confirmation step when generating drafts #2787

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

SF-3028 Add final confirmation step when generating drafts #2787

wants to merge 19 commits into from
+319 −31

Commits on Dec 3, 2024

  1. Switched draft generation to horizontal stepper 

    This involved a few overrides on the stepper to get it to look normal, including enabling header hover when a step is incomplete, disabling font size growth for the selected step, and hiding the odd "edit" state which cluttered up the stepper.

Also removed the "initial/steps" tab group on the parent and the extra, persistent Back button.
    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    b55f593 View commit details
    Browse the repository at this point in the history

  2. Removed optional and initial back arrow

    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    2eb38b8 View commit details
    Browse the repository at this point in the history

  3. Refreshing training books on step change

    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    942a404 View commit details
    Browse the repository at this point in the history

  4. Cleanup and unit test

    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    12d49e3 View commit details
    Browse the repository at this point in the history

  5. Initial stab at layout 

    Lots of the component logic is handjammed, but we can fix this once the preceding tasks are merged.
    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    3f85f33 View commit details
    Browse the repository at this point in the history

  6. Further layout adjustments 

    Switched to a card design. The gray box was too much color, decreased contrast, and just didn't look great.

Inserted the titles from Step 1, with the source name added to the second.
    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    68d1ec4 View commit details
    Browse the repository at this point in the history

  7. Added ability to collapse similar books into ranges 

    Also displaying the display name of the language codes for the training table header (assuming it's retrievable).
    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    16986a4 View commit details
    Browse the repository at this point in the history

  8. Further tweaks to the books display

    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    b8d97b0 View commit details
    Browse the repository at this point in the history

  9. Localizing book names

    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    3eb5acd View commit details
    Browse the repository at this point in the history

  10. Translate books are on one line 

    And force synced the book font size
    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    7cd2215 View commit details
    Browse the repository at this point in the history

  11. Combined training ranges onto one line, comma separated 

    I think my previous iteration is more readable, but I'm content if others are fine with it.
    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    016033a View commit details
    Browse the repository at this point in the history

  12. Localization

    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    9789409 View commit details
    Browse the repository at this point in the history

  13. Remove a bottom margin

    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    812d7e1 View commit details
    Browse the repository at this point in the history

  14. Fixed draft generation steps tests

    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    e61e5d5 View commit details
    Browse the repository at this point in the history

  15. Using i18n.enumerateList for the training books 

    This does mean we won't have as much control about word wrapping.
    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    fed1a86 View commit details
    Browse the repository at this point in the history

  16. Fixed a test

    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    325da8c View commit details
    Browse the repository at this point in the history

  17. Added test coverage for the new methods

    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    f6ccd99 View commit details
    Browse the repository at this point in the history

  18. Removed this

    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    c7c4ce3 View commit details
    Browse the repository at this point in the history

  19. Renamed title and header to use "Summary"

    @josephmyers
    josephmyers committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    20161d0 View commit details
    Browse the repository at this point in the history