-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create improved book toggling component #2680
base: master
Are you sure you want to change the base?
Conversation
7224510
to
a3defeb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2680 +/- ##
==========================================
- Coverage 78.34% 78.28% -0.06%
==========================================
Files 521 522 +1
Lines 30154 30187 +33
Branches 4930 4926 -4
==========================================
+ Hits 23625 23633 +8
- Misses 5755 5792 +37
+ Partials 774 762 -12 ☔ View full report in Codecov by Sentry. |
24adb93
to
8ee984a
Compare
8ee984a
to
1a80a2f
Compare
My vote would be the book toggle with no border. I really like the info display of book completion percentage when hovering over the book! |
This is a proposed component for toggling a book when selecting books (an alternative to mat chips).
I'm opening it as a draft PR so Storybook will get published to Chromatic.
I'm proposing a design, and I think this branch can serve as a basis if others want to propose a different design, by using this as a starting point.
For option A (what this PR originally had), see this storybook:
https://644bffe327c540a62f0fd260-wvwluxllwf.chromatic.com/?path=/story/translate-togglebook--selected
This change is