Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark corpus endpoints obsolete #535

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Mark corpus endpoints obsolete #535

merged 3 commits into from
Nov 5, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Nov 1, 2024

  • ignore CS0612 obsolete endpoint warnings in E2E and integration tests

Resolves #515


This change is Reviewable

* ignore CS0612 obsolete endpoint warnings in E2E and integration tests
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.95%. Comparing base (e2f1f25) to head (e07706c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   56.95%   56.95%           
=======================================
  Files         299      299           
  Lines       15734    15734           
  Branches     2173     2173           
=======================================
  Hits         8962     8962           
  Misses       6122     6122           
  Partials      650      650           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also mark obsolete properties in the relevant DTOs.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@johnml1135
Copy link
Collaborator Author

Done

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93 and @johnml1135)


src/Serval/test/Serval.ApiServer.IntegrationTests/Serval.ApiServer.IntegrationTests.csproj line 16 at r2 (raw file):

		<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
		<GenerateDocumentationFile>true</GenerateDocumentationFile>
		<NoWarn>$(NoWarn);CS1591;CS1573;CS0612</NoWarn>

We should use #pragma warning disable CS0612 like you did in the controller.

@johnml1135
Copy link
Collaborator Author

src/Serval/test/Serval.ApiServer.IntegrationTests/Serval.ApiServer.IntegrationTests.csproj line 16 at r2 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

We should use #pragma warning disable CS0612 like you did in the controller.

done

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@johnml1135 johnml1135 merged commit 57ce385 into main Nov 5, 2024
3 checks passed
@johnml1135 johnml1135 deleted the obsolete_corpus branch November 5, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "obsolete" property to corpora
3 participants