-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GetTasksForQueueAsync #534
Conversation
* Speed up NmtQueue test with parallel corpora
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #534 +/- ##
=======================================
Coverage 56.95% 56.95%
=======================================
Files 299 299
Lines 15734 15734
Branches 2173 2173
=======================================
Hits 8962 8962
Misses 6122 6122
Partials 650 650 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Enkidu93 and @johnml1135)
src/Machine/src/Serval.Machine.Shared/Services/ClearMLService.cs
line 165 at r1 (raw file):
var tasks = (JsonArray?)result?["data"]?["queue"]?["entries"]; IEnumerable<string> taskIds = tasks?.Select(t => (string)t?["task"]!) ?? new List<string>(); var tasksById = await GetTasksByIdAsync(taskIds, cancellationToken);
I'm guessing this change was made for debugging purposes. It can probably be reverted.
src/Serval/test/Serval.E2ETests/ServalApiTests.cs
line 218 at r1 (raw file):
Assert.That(engine.IsModelPersisted, Is.True); string[] books = ["bible_LARGEFILE.txt"]; var train_corpus = await _helperClient.MakeParallelTextCorpus(books, "es", "en", false);
Please use an explict type if the type is specified elsewhere on the line.
Previously, ddaspit (Damien Daspit) wrote…
Done. |
Previously, ddaspit (Damien Daspit) wrote…
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)
This change is