Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetTasksForQueueAsync #534

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Fix GetTasksForQueueAsync #534

merged 2 commits into from
Nov 5, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Nov 1, 2024

* Speed up NmtQueue test with parallel corpora
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.95%. Comparing base (e2f1f25) to head (6069efc).

Files with missing lines Patch % Lines
...c/Serval.Machine.Shared/Services/ClearMLService.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #534   +/-   ##
=======================================
  Coverage   56.95%   56.95%           
=======================================
  Files         299      299           
  Lines       15734    15734           
  Branches     2173     2173           
=======================================
  Hits         8962     8962           
  Misses       6122     6122           
  Partials      650      650           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Enkidu93 and @johnml1135)


src/Machine/src/Serval.Machine.Shared/Services/ClearMLService.cs line 165 at r1 (raw file):

        var tasks = (JsonArray?)result?["data"]?["queue"]?["entries"];
        IEnumerable<string> taskIds = tasks?.Select(t => (string)t?["task"]!) ?? new List<string>();
        var tasksById = await GetTasksByIdAsync(taskIds, cancellationToken);

I'm guessing this change was made for debugging purposes. It can probably be reverted.


src/Serval/test/Serval.E2ETests/ServalApiTests.cs line 218 at r1 (raw file):

        Assert.That(engine.IsModelPersisted, Is.True);
        string[] books = ["bible_LARGEFILE.txt"];
        var train_corpus = await _helperClient.MakeParallelTextCorpus(books, "es", "en", false);

Please use an explict type if the type is specified elsewhere on the line.

@johnml1135
Copy link
Collaborator Author

src/Machine/src/Serval.Machine.Shared/Services/ClearMLService.cs line 165 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

I'm guessing this change was made for debugging purposes. It can probably be reverted.

Done.

@johnml1135
Copy link
Collaborator Author

src/Serval/test/Serval.E2ETests/ServalApiTests.cs line 218 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

Please use an explict type if the type is specified elsewhere on the line.

Done.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@johnml1135 johnml1135 merged commit c45a597 into main Nov 5, 2024
3 checks passed
@johnml1135 johnml1135 deleted the fix_queue_depth branch November 5, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants