Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry clearml calls on 429 responses. #531

Merged
merged 1 commit into from
Oct 31, 2024
Merged

retry clearml calls on 429 responses. #531

merged 1 commit into from
Oct 31, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Oct 31, 2024

#524


This change is Reviewable

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this, John! Have we figured out with ClearML if we're actually over-requesting because of an error in our code? Also, might it be wise to see if them upping the limit fixes things before introducing another change like this (i.e., this might increase the number of requests even while they're upping our limit)?

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135
Copy link
Collaborator Author

They just removed the limit entirely. The issue may be that all of our servers present themselves as the same IP address. Also, each agent calls out to ClearML every 2 seconds. It's a number of things together.

@johnml1135
Copy link
Collaborator Author

Moreover, we were intending the code to handle the 429 case and it was a mistake that it didn't. That is why I am ok going forward with this change.

@johnml1135 johnml1135 merged commit b8277f2 into main Oct 31, 2024
3 checks passed
@johnml1135 johnml1135 deleted the clearml_429_retry branch October 31, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants