-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up USFM pretranslations for Parallel corpus #529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @johnml1135)
src/Serval/src/Serval.Translation/Services/PretranslationService.cs
line 55 at r1 (raw file):
else if (parallelCorpus is not null) { sourceFile = parallelCorpus.SourceCorpora[0].Files[0];
What about a situation in which we're using a parallel corpus that has two source (or target) corpora: one that includes MAT & MRK and another that includes MRK & JHN. Won't be run into issues if we try and insert pretranslations into the USFM for JHN from a project that isn't the one that contains JHN?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
==========================================
+ Coverage 56.91% 56.98% +0.06%
==========================================
Files 299 299
Lines 15706 15738 +32
Branches 2168 2174 +6
==========================================
+ Hits 8939 8968 +29
- Misses 6119 6120 +1
- Partials 648 650 +2 ☔ View full report in Codecov by Sentry. |
Previously, Enkidu93 (Eli C. Lowry) wrote…
Resolved through the meetings we had. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, 4 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit and @Enkidu93)
#522
This change is