Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up USFM pretranslations for Parallel corpus #529

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Oct 31, 2024

#522


This change is Reviewable

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @johnml1135)


src/Serval/src/Serval.Translation/Services/PretranslationService.cs line 55 at r1 (raw file):

        else if (parallelCorpus is not null)
        {
            sourceFile = parallelCorpus.SourceCorpora[0].Files[0];

What about a situation in which we're using a parallel corpus that has two source (or target) corpora: one that includes MAT & MRK and another that includes MRK & JHN. Won't be run into issues if we try and insert pretranslations into the USFM for JHN from a project that isn't the one that contains JHN?

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 88.09524% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.98%. Comparing base (6e9b736) to head (fa6a04d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rval.Translation/Services/PretranslationService.cs 76.92% 2 Missing and 1 partial ⚠️
...rval.Machine.Shared/Services/PreprocessBuildJob.cs 83.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
+ Coverage   56.91%   56.98%   +0.06%     
==========================================
  Files         299      299              
  Lines       15706    15738      +32     
  Branches     2168     2174       +6     
==========================================
+ Hits         8939     8968      +29     
- Misses       6119     6120       +1     
- Partials      648      650       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135
Copy link
Collaborator Author

src/Serval/src/Serval.Translation/Services/PretranslationService.cs line 55 at r1 (raw file):

Previously, Enkidu93 (Eli C. Lowry) wrote…

What about a situation in which we're using a parallel corpus that has two source (or target) corpora: one that includes MAT & MRK and another that includes MRK & JHN. Won't be run into issues if we try and insert pretranslations into the USFM for JHN from a project that isn't the one that contains JHN?

Resolved through the meetings we had.

Copy link
Collaborator Author

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, 4 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit and @Enkidu93)

@johnml1135 johnml1135 merged commit f872bfa into main Oct 31, 2024
1 of 2 checks passed
@johnml1135 johnml1135 deleted the usfm_parallel_pretranslations branch October 31, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants