Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peter's fix #525

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Peter's fix #525

merged 1 commit into from
Oct 30, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Oct 29, 2024

Fox #523 - and make the test catch it.


This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.97%. Comparing base (2c0dd11) to head (f620097).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
+ Coverage   56.86%   56.97%   +0.10%     
==========================================
  Files         299      299              
  Lines       15686    15686              
  Branches     2165     2165              
==========================================
+ Hits         8920     8937      +17     
+ Misses       6114     6101      -13     
+ Partials      652      648       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135 johnml1135 merged commit b6b9ae4 into main Oct 30, 2024
2 checks passed
@johnml1135 johnml1135 deleted the fix_pretranslate_chapter_filter branch October 30, 2024 16:42
Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants