Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retain build files #481

Merged
merged 1 commit into from
Sep 10, 2024
Merged

retain build files #481

merged 1 commit into from
Sep 10, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Sep 9, 2024

Fix for #468


This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit September 9, 2024 19:13
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.59%. Comparing base (c7f1214) to head (e6a2277).

Files with missing lines Patch % Lines
...val.Machine.Shared/Services/PostprocessBuildJob.cs 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #481   +/-   ##
=======================================
  Coverage   56.59%   56.59%           
=======================================
  Files         275      275           
  Lines       14174    14179    +5     
  Branches     1908     1909    +1     
=======================================
+ Hits         8022     8025    +3     
- Misses       5563     5564    +1     
- Partials      589      590    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't need to happen in this PR, but we need to come up with a strategy for cleaning these files up after a specified amount of time. It would be good to know if there are any other changes, such as model changes, that are needed to support the cleanup strategy.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit e56cdf7 into main Sep 10, 2024
3 checks passed
@johnml1135 johnml1135 deleted the retain_build_files branch September 10, 2024 00:02
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't approve this PR. I was waiting on a response about the strategy for cleaning up the files.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants