Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate accidentally removed logic from https://github.com/sillsdev/machine/pull/207 #467

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Incorporate accidentally removed logic from https://github.com/sillsdev/machine/pull/207 #467

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a642f72
Incorporate accidentally removed logic from https://github.com/sillsd…
Enkidu93 Aug 26, 2024
dab0888
Add filter to AlignTrainCorpus as well
Enkidu93 Aug 26, 2024
7eb9a7c
Add tests to make sure we're not parsing unselected books
Enkidu93 Aug 27, 2024
342830c
Fix test names
Enkidu93 Aug 27, 2024
6d11ca1
Add test covering AlignPretranslateCorpus
Enkidu93 Aug 27, 2024
61c4106
Review changes
Enkidu93 Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Machine/src/Serval.Machine.Shared/Services/PreprocessBuildJob.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ CancellationToken cancellationToken
}
}

foreach (Row row in AlignPretranslateCorpus(sourceTextCorpora[0], targetTextCorpus))
foreach (Row row in AlignPretranslateCorpus(corpus, sourceTextCorpora[0], targetTextCorpus))
{
if (
IsInPretranslate(row, corpus)
Expand Down Expand Up @@ -374,8 +374,13 @@ private static bool IsInChapters(IReadOnlyDictionary<string, HashSet<int>> bookC
}
}

private static IEnumerable<Row> AlignPretranslateCorpus(ITextCorpus srcCorpus, ITextCorpus trgCorpus)
private static IEnumerable<Row> AlignPretranslateCorpus(Corpus corpus, ITextCorpus srcCorpus, ITextCorpus trgCorpus)
{
IEnumerable<string>? textIds = corpus.PretranslateChapters is not null
? corpus.PretranslateChapters.Keys
: corpus.PretranslateTextIds;
srcCorpus = srcCorpus.FilterTexts(textIds);
trgCorpus = trgCorpus.FilterTexts(textIds);
int rowCount = 0;
StringBuilder srcSegBuffer = new();
StringBuilder trgSegBuffer = new();
Expand Down
Loading