Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-add missing verses in target USFM #414

Closed
johnml1135 opened this issue Jun 14, 2024 · 3 comments
Closed

Auto-add missing verses in target USFM #414

johnml1135 opened this issue Jun 14, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@johnml1135
Copy link
Collaborator

johnml1135 commented Jun 14, 2024 •
edited
Loading

We should just do this. Spin off from #405.

Specifically, for verse text (not non-verse text), if there is a pretranslation available and a target USFM file, but the target USFM file only has a few verses, create the other verses in the appropriate locations and fill it in with the pretranslations.
@johnml1135 johnml1135 added the enhancement New feature or request label Jun 14, 2024
@johnml1135 johnml1135 self-assigned this Jun 14, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Serval Jun 14, 2024
@johnml1135 johnml1135 mentioned this issue Jun 14, 2024
Closed
@johnml1135 johnml1135 removed their assignment Jun 14, 2024
@ddaspit
Copy link
Contributor

ddaspit commented Jun 14, 2024

We probably want this to be configurable. I don't think we should automatically mess with the structure of a target translation.

@johnml1135 johnml1135 mentioned this issue Jun 18, 2024
Closed
johnml1135 added a commit to sillsdev/machine that referenced this issue Jun 19, 2024
@johnml1135
fix verse numbers missing text - sillsdev/serval#411
1ba0556 
auto-add missing verses - sillsdev/serval#414
@ddaspit
Copy link
Contributor

ddaspit commented Jun 19, 2024

Let's hold off on implementing this until we get specific requirements from Scripture Forge.

johnml1135 added a commit to sillsdev/machine that referenced this issue Jun 20, 2024
@johnml1135
auto-add missing verses - sillsdev/serval#414
37f9c0c
@johnml1135
Copy link
Collaborator Author

This is not relevant for now. #405 is the resolution needed at this time.

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Serval Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Serval
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddaspit @johnml1135