Be explicit about engineId in every log (#490)

Only log 500 codes
sillsdev · Sep 12, 2024 · cf71555 · cf71555
1 parent df6673e
commit cf71555
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/Serval/src/Serval.Shared/Controllers/ErrorResultFilter.cs b/src/Serval/src/Serval.Shared/Controllers/ErrorResultFilter.cs
@@ -7,7 +7,7 @@ public class ErrorResultFilter(ILoggerFactory loggerFactory) : IAlwaysRunResultF
 
     public void OnResultExecuted(ResultExecutedContext context)
     {
-        if (context.HttpContext.Response.StatusCode >= 400)
+        if (context.HttpContext.Response.StatusCode >= 500)
         {
             _logger.LogInformation(
                 "Client {client} made request:\n {request}.\n Serval responded with code {statusCode}. Trace: {activityId}",

diff --git a/src/Serval/src/Serval.Translation/Controllers/TranslationEnginesController.cs b/src/Serval/src/Serval.Translation/Controllers/TranslationEnginesController.cs
@@ -704,7 +704,12 @@ CancellationToken cancellationToken
         );
         if (usfm == "")
             return NoContent();
-        _logger.LogInformation("Returning USFM for {TextId} in {CorpusId} of {EngineId}", textId, corpusId, id);
+        _logger.LogInformation(
+            "Returning USFM for {TextId} in engine {EngineId} for corpus {corpusId}",
+            textId,
+            id,
+            corpusId
+        );
         return Content(usfm, "text/plain");
     }