Fix LT-21939 #264
Merged
Fix LT-21939 #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #264 +/- ##
==========================================
+ Coverage 69.95% 69.97% +0.01%
==========================================
Files 379 379
Lines 31770 31785 +15
Branches 4454 4456 +2
==========================================
+ Hits 22225 22240 +15
Misses 8511 8511
Partials 1034 1034 ☔ View full report in Codecov by Sentry. |
ddaspit
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)
ddaspit
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-21939. I was able to reproduce the bug by adding an APR to a unit test (deleteVowelSuffix in AffixProcessRuleTests.SubsumedAffix), and then I tried different modifications to the code until it passed the unit test. In the process, I discovered what I think is a bug related to the TruncateRules test, which is that the code was not recording the truncate rule in the output even though it was needed to parse words. I hope that this is correct.
This change is