-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix forever loop #260
Fix forever loop #260
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 69.95% 69.95% -0.01%
==========================================
Files 379 379
Lines 31767 31770 +3
Branches 4454 4454
==========================================
+ Hits 22223 22225 +2
- Misses 8510 8511 +1
Partials 1034 1034 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @johnml1135)
src/SIL.Machine/Corpora/ParallelTextCorpus.cs
line 579 at r1 (raw file):
} bool result = _enumerator.MoveNext();
You should set _enumeratorHasMoreData
instead of result
, so that the field is set consistently in all cases.
src/SIL.Machine/Corpora/ParallelTextCorpus.cs
line 584 at r1 (raw file):
} public void Reset()
You should reset _enumeratorHasMoreData
here.
Previously, ddaspit (Damien Daspit) wrote…
Done. |
Previously, ddaspit (Damien Daspit) wrote…
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)
This change is