Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If there are no enumerators, it enters an infinite loop. #257

Merged
merged 2 commits into from
Oct 15, 2024
Merged

If there are no enumerators, it enters an infinite loop. #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0569d1e
If there are no enumerators, it enters an infinite loop.
johnml1135 Oct 11, 2024
4c31e2f
Add test
johnml1135 Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/SIL.Machine/Utils/EnumerableExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ Func<IEnumerable<TSource>, TResult> selector
{
// ToList is necessary to avoid deferred execution
List<IEnumerator<TSource>> enumerators = source.Select(seq => seq.GetEnumerator()).ToList();
if (enumerators.Count == 0)
yield break;
try
{
while (true)
Expand Down
23 changes: 23 additions & 0 deletions tests/SIL.Machine.Tests/Utils/EnumberableExtensionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
using NUnit.Framework;

namespace SIL.Machine.Utils;

[TestFixture]
public class EnumerableExtensionTests
{
[Test]
public void ZipMany_None()
{
var seqs = new List<IEnumerable<int>>();
IEnumerable<int> result = seqs.ZipMany(x => x.Sum());
Assert.That(result, Is.Empty);
}

[Test]
public void ZipMany_Two()
{
var seqs = new List<IEnumerable<int>> { new[] { 1, 2, 3 }, new[] { 4, 5, 6 } };
IEnumerable<int> result = seqs.ZipMany(x => x.Sum());
Assert.That(result, Is.EqualTo(new[] { 5, 7, 9 }));
}
}
Loading