Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend manual test to process multiple projects including zipped projects #227

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Jul 15, 2024

Addresses sillsdev/serval#429


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (554447f) to head (5c2f2cf).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #227   +/-   ##
=======================================
  Coverage   69.67%   69.67%           
=======================================
  Files         374      374           
  Lines       31317    31317           
  Branches     4387     4387           
=======================================
  Hits        21821    21821           
  Misses       8478     8478           
  Partials     1018     1018           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135
Copy link
Collaborator

:lgtm:

@johnml1135
Copy link
Collaborator

tests/SIL.Machine.Tests/Corpora/UsfmManualTests.cs line 71 at r1 (raw file):

    [Ignore("This is for manual testing only.  Remove this tag to run the test.")]
    public async Task CreateUsfmFile()
    {

Can you put in a comment on how to use it? What is the range of paratext projects that this can accept? Any arbitrarily nested set of zip files or folders of unzipped paratext projects? How about instructions - place your zipped para text projects in this folder, remove the ignore and then run...

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit and @Enkidu93)

Copy link
Collaborator Author

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit and @johnml1135)


tests/SIL.Machine.Tests/Corpora/UsfmManualTests.cs line 71 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Can you put in a comment on how to use it? What is the range of paratext projects that this can accept? Any arbitrarily nested set of zip files or folders of unzipped paratext projects? How about instructions - place your zipped para text projects in this folder, remove the ignore and then run...

Done.

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit 3911dd6 into master Jul 16, 2024
4 checks passed
@johnml1135 johnml1135 deleted the usfm_testing branch July 16, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants