-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend manual test to process multiple projects including zipped projects #227
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #227 +/- ##
=======================================
Coverage 69.67% 69.67%
=======================================
Files 374 374
Lines 31317 31317
Branches 4387 4387
=======================================
Hits 21821 21821
Misses 8478 8478
Partials 1018 1018 ☔ View full report in Codecov by Sentry. |
Can you put in a comment on how to use it? What is the range of paratext projects that this can accept? Any arbitrarily nested set of zip files or folders of unzipped paratext projects? How about instructions - place your zipped para text projects in this folder, remove the ignore and then run... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit and @Enkidu93)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit and @johnml1135)
tests/SIL.Machine.Tests/Corpora/UsfmManualTests.cs
line 71 at r1 (raw file):
Previously, johnml1135 (John Lambert) wrote…
Can you put in a comment on how to use it? What is the range of paratext projects that this can accept? Any arbitrarily nested set of zip files or folders of unzipped paratext projects? How about instructions - place your zipped para text projects in this folder, remove the ignore and then run...
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)
Addresses sillsdev/serval#429
This change is