Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for empty string #226

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Jul 12, 2024

Fixes sillsdev/serval#395

Parallel PR: sillsdev/machine.py#110


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (39df17e) to head (1b072a9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   69.67%   69.67%           
=======================================
  Files         374      374           
  Lines       31314    31317    +3     
  Branches     4386     4387    +1     
=======================================
+ Hits        21818    21821    +3     
  Misses       8478     8478           
  Partials     1018     1018           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135 johnml1135 merged commit 554447f into master Jul 16, 2024
3 checks passed
@johnml1135 johnml1135 deleted the scripture_range_parser_no_error_on_empty_string branch July 16, 2024 17:39
@Enkidu93
Copy link
Collaborator Author

@johnml1135 , @ddaspit I was waiting to merge until sillsdev/machine.py#110 went through, but it shouldn't cause problems. Could someone approve that?

@johnml1135
Copy link
Collaborator

Machine.py has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScriptureRangeParser shouldn't throw exception when passed an empty string
4 participants