Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly parse table in duplicate verse #222

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Jul 11, 2024

sillsdev/serval#424


This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit July 11, 2024 12:39
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.65%. Comparing base (b11f9a0) to head (d0bf8e6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   69.65%   69.65%           
=======================================
  Files         374      374           
  Lines       31298    31300    +2     
  Branches     4383     4384    +1     
=======================================
+ Hits        21801    21803    +2     
  Misses       8479     8479           
  Partials     1018     1018           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit 385213e into master Jul 11, 2024
4 checks passed
@ddaspit ddaspit deleted the table_in_duplicate_verse branch July 22, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants