fix missing last verse

[johnml1135]

fix Last verse blank in USFM in a specific translation engine - #408

This change is 

[ddaspit]

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @johnml1135)

---

src/SIL.Machine/Corpora/IUsfmParserHandler.cs line 34 at r1 (raw file):

        /// Book element contains the description as text
        /// </summary>
        void EndBook(UsfmParserState state, string marker);

Why did you remove the marker parameter?

---

src/SIL.Machine/Corpora/UsfmParser.cs line 632 at r1 (raw file):

            {
                case UsfmElementType.Book:
                    Handler?.EndBook(State, element.Marker);

We should be able to fix this by implementing the EndUsfm method in the UsfmTextUpdater class instead of changing the semantics of the EndBook method.

[ddaspit]

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

---

src/SIL.Machine/Corpora/UsfmParser.cs line 632 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

We should be able to fix this by implementing the EndUsfm method in the UsfmTextUpdater class instead of changing the semantics of the EndBook method.

Done

[johnml1135]

src/SIL.Machine/Corpora/IUsfmParserHandler.cs line 34 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

Why did you remove the marker parameter?

It isn't needed - also it isn't called when a new book starts, but when the existing book ends, which does not occur with a marker but rather just no more characters.