Recreate the USFM text updating issue in unit tests. #206
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #206 +/- ##
==========================================
+ Coverage 67.32% 67.37% +0.04%
==========================================
Files 441 441
Lines 35021 35134 +113
Branches 4700 4702 +2
==========================================
+ Hits 23579 23672 +93
- Misses 10352 10372 +20
Partials 1090 1090 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewed 1 of 5 files at r1, 1 of 5 files at r2, 9 of 9 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ddaspit)
- fixes sillsdev/serval#399 - fixes sillsdev/serval#398 - Line and column number with USFM errors.
There was a problem hiding this comment.
Reviewed 4 of 4 files at r5, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 5 files at r1, 1 of 5 files at r2, 5 of 9 files at r4, 4 of 4 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)
.ignore line 1 at r5 (raw file):
!tests/SIL.Machine.Tests/Corpora/TestData/usfm/source/*
What is this file used for?
|
Previously, ddaspit (Damien Daspit) wrote…
These are where the manual tests can be run. By adding this file, the files put here will be searchable, but will not be added to git. https://stackoverflow.com/questions/55949132/vscode-how-to-get-file-search-not-content-to-include-git-ignored-files/55949239#55949239 |
Make USFM updating errors more explicit: sillsdev/serval#398
@ddaspit - can up finish resolving the USFM updating parse stack empty issue?
This change is