Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle corrupted SMT models #68

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Correctly handle corrupted SMT models #68

merged 1 commit into from
Nov 22, 2023

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Nov 21, 2023

This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (63738c2) 86.74% compared to head (3b850ff) 86.76%.

Files Patch % Lines
machine/translation/thot/thot_smt_model.py 75.00% 1 Missing ⚠️
machine/translation/thot/thot_utils.py 75.00% 1 Missing ⚠️
...hine/translation/thot/thot_word_alignment_model.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   86.74%   86.76%   +0.01%     
==========================================
  Files         225      225              
  Lines       13526    13558      +32     
==========================================
+ Hits        11733    11763      +30     
- Misses       1793     1795       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit d324ec7 into main Nov 22, 2023
14 checks passed
@ddaspit ddaspit deleted the corrupt-model branch November 22, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants