Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path issue for loading from custom_normalizer directory #48

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

mshannon-sil
Copy link
Collaborator

@mshannon-sil mshannon-sil commented Oct 23, 2023

I changed the code so that it doesn't assume the project root directory is the same as the current working directory when loading a tokenizer from the custom_normalizer directory.


This change is Reviewable

@mshannon-sil mshannon-sil added the bug Something isn't working label Oct 23, 2023
@mshannon-sil mshannon-sil added this to the 1.1 Mother Tongue MVP milestone Oct 23, 2023
@mshannon-sil mshannon-sil self-assigned this Oct 23, 2023
@mshannon-sil mshannon-sil linked an issue Oct 23, 2023 that may be closed by this pull request
Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mshannon-sil)

@johnml1135 johnml1135 merged commit d7f9d69 into main Oct 24, 2023
@ddaspit ddaspit deleted the tokenizer_fix branch October 26, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Unable to find custom_normalizer directory
2 participants