Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moses punct #140

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Fix moses punct #140

merged 2 commits into from
Nov 11, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Nov 8, 2024

and a config issue.

This is to resolve the final issues for migrating to the newer version of Transformers, etc.


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.30%. Comparing base (730ea67) to head (5e2ac47).

Files with missing lines Patch % Lines
...translation/huggingface/hugging_face_nmt_engine.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
- Coverage   88.31%   88.30%   -0.01%     
==========================================
  Files         275      275              
  Lines       16168    16171       +3     
==========================================
+ Hits        14278    14280       +2     
- Misses       1890     1891       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit 0fb9518 into main Nov 11, 2024
14 checks passed
@johnml1135 johnml1135 deleted the fix_moses_punct branch November 11, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants