Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Paratext/USFM processing tutorial #130

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Add Paratext/USFM processing tutorial #130

merged 1 commit into from
Oct 17, 2024

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Oct 17, 2024

  • replace "strip_all_text" and "prefer_existing_text" parameters with a single enum parameter

This change is Reviewable

- replace "strip_all_text" and "prefer_existing_text" parameters with a single enum parameter
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.12%. Comparing base (b7c06c8) to head (3468ae6).

Files with missing lines Patch % Lines
tests/corpora/test_usfm_manual.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files         273      273           
  Lines       16030    16034    +4     
=======================================
+ Hits        14126    14130    +4     
  Misses       1904     1904           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit cec61de into main Oct 17, 2024
14 checks passed
@ddaspit ddaspit deleted the pt-usfm-tutorial branch October 17, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants