Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MT tutorial #129

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Add MT tutorial #129

merged 3 commits into from
Oct 17, 2024

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Oct 16, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 65.62500% with 11 lines in your changes missing coverage. Please review.

Project coverage is 88.07%. Comparing base (cec61de) to head (975a799).

Files with missing lines Patch % Lines
machine/translation/translation_suggester.py 50.00% 4 Missing ⚠️
machine/translation/truecaser.py 55.55% 4 Missing ⚠️
...tion/huggingface/hugging_face_nmt_model_trainer.py 85.71% 2 Missing ⚠️
...translation/huggingface/hugging_face_nmt_engine.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   88.12%   88.07%   -0.05%     
==========================================
  Files         273      273              
  Lines       16034    16039       +5     
==========================================
- Hits        14130    14127       -3     
- Misses       1904     1912       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135
Copy link
Collaborator

machine/jobs/huggingface/hugging_face_nmt_model_factory.py line 80 at r1 (raw file):

            corpus,
            src_lang=self._config.src_lang,
            tgt_lang=self._config.trg_lang,

why are some trg and some tgt? I thought we were only doing trg...

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)

Copy link
Contributor Author

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 11 of 13 files reviewed, 1 unresolved discussion (waiting on @johnml1135)


machine/jobs/huggingface/hugging_face_nmt_model_factory.py line 80 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

why are some trg and some tgt? I thought we were only doing trg...

I was trying to make all of the parameter names consistent for the Huggingface classes, but I didn't want to break the integration with Serval, so I left trg_lang alone. I shouldn't have changed add_unk_trg_tokens in the settings.yaml, since that is potentially a breaking change with Serval and also makes it inconsistent with the trg_lang setting, so I changed it back. Unfortunately, that means that the jobs settings and the Huggingface classes are now inconsistent, but I willing to live with that, so we don't break Serval.

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit 2fae0c6 into main Oct 17, 2024
14 checks passed
@ddaspit ddaspit deleted the mt-tutorial branch October 17, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants