fix default for BiblicalTermsListSetting #125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason that
BiblicalTermsListSetting
wasn't allowed to be optional was because the default was set to""
, but the check to see if aBiblicalTermsListSetting
exists in the Settings.xml usesif biblical_terms_list_setting is not None
. I've removed the explicit default so that if it's not found, it assignsNone
, and the subsequent check will work properly. This bug is only in machine.py, not in Machine.I tested this by temporarily removing the
BiblicalTermsListSetting
line in theSettings.xml
of theTes
folder, and then verifying that the change in defaults successfully changed tests from failing to passing. However, there were a couple tests that depended on the contents ofBiblicalTermsListSetting
not being empty/default, so I had to undo that change inSettings.xml
when committing.Should I create test case(s) for the
parse()
method inParatextProjectSettingsParserBase
along with this bug fix? I'd imagine that would require another test file since there isn't one forParatextProjectSettingsParserBase
, and then adding a corresponding test file in Machine as well to keep the repos matching.This change is