Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PNPM to 9.15.5 #1440

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Bump PNPM to 9.15.5 #1440

wants to merge 3 commits into from

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented Feb 3, 2025

PNPM v9.15.5 brings in several bugfixes, at least one of which (running preprepare scripts from packages on pnpm install, and "preprepare" is not a typo) we'll probably want to have when we upgrade our SvelteKit dependency.

Fixes #1430.
Also fixes #1429.
Also fixes #1446.

PNPM v9.15.5 brings in several bugfixes, at least one of which (running
preprepare scripts from packages on pnpm install, and "preprepare" is
not a typo) we'll probably want to have when we upgrade our SvelteKit
dependency.
@rmunn rmunn self-assigned this Feb 3, 2025
@rmunn rmunn requested a review from myieye February 3, 2025 17:18
Copy link

github-actions bot commented Feb 3, 2025

UI unit Tests

12 tests  ±0   12 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 00fea22. ± Comparison against base commit 3cc97f1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 3, 2025

C# Unit Tests

104 tests  ±0   104 ✅ ±0   5s ⏱️ ±0s
 16 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 00fea22. ± Comparison against base commit 3cc97f1.

♻️ This comment has been updated with latest results.

@rmunn
Copy link
Contributor Author

rmunn commented Feb 3, 2025

PNPM 9.15.5 was just released yesterday, and I'm seeing errors from Node Corepack when I try to run corepack enable with PNPM 9.15.5 listed in package.json. I'll convert this PR to draft and try again later, when hopefully they'll have gotten it straightened out.

@rmunn rmunn removed the request for review from myieye February 3, 2025 17:41
@rmunn rmunn marked this pull request as draft February 3, 2025 17:41
@hahn-kev
Copy link
Collaborator

hahn-kev commented Feb 4, 2025

It looks like the dockerfile is still referencing the old version, funny I made this change yesterday. In both the dev and prod docker files they're running RUN corepack enable && corepack prepare [email protected] --activate so you'll need to update the pnpm version or figure out how to not hardcode it.

@rmunn
Copy link
Contributor Author

rmunn commented Feb 4, 2025

It looks like the dockerfile is still referencing the old version, funny I made this change yesterday. In both the dev and prod docker files they're running RUN corepack enable && corepack prepare [email protected] --activate so you'll need to update the pnpm version or figure out how to not hardcode it.

PNPM versions from 9.8 onwards will self-update when they encounter a packageManager field in package.json that's higher than the current version, so we don't actually need to update the Dockerfile anymore. When we bump to PNPM 10 we may want to run corepack prepare pnpm@10 --activate (haven't tested that yet, it's possible that PNPM 9 will self-update to 10 if specified in packageManager). But all we need to do is update the version in package.json and it will automatically run that version of PNPM without changing the Dockerfile, which means fewer container layer rebuilds. It's great!

@rmunn rmunn marked this pull request as ready for review February 4, 2025 16:56
@rmunn rmunn requested review from hahn-kev and removed request for hahn-kev February 4, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants