-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up goal redux to match other redux #2974
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2974 +/- ##
==========================================
- Coverage 72.75% 72.72% -0.04%
==========================================
Files 267 266 -1
Lines 10204 10200 -4
Branches 1196 1196
==========================================
- Hits 7424 7418 -6
- Misses 2430 2431 +1
- Partials 350 351 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
src/components/App/DefaultState.ts
line 1 at r1 (raw file):
import { defaultState as goalsState } from "components/GoalTimeline/Redux/GoalReduxTypes";
The component is GoalTimeline
, not goal. This should not be changed here.
The component should not be changed to Goal
because that would be too confusing since there is another collection of React elements in ./src/goals
.
Code quote:
import { defaultState as goalsState } from "components/GoalTimeline/Redux/GoalReduxTypes";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 21 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec and @jmgrady)
src/components/App/DefaultState.ts
line 1 at r1 (raw file):
Previously, jmgrady (Jim Grady) wrote…
The component is
GoalTimeline
, not goal. This should not be changed here.
The component should not be changed toGoal
because that would be too confusing since there is another collection of React elements in./src/goals
.
Ah, very good point. Though with the way components/GoalTimeline/Redux
is used, I think it's more fitting to move it to goals/Redux
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 19 of 19 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
This change is