Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let back button get stuck on loading screen #2971

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 26, 2024

Resolves #1748


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working frontend goal labels Feb 26, 2024
@imnasnainaec imnasnainaec self-assigned this Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.94%. Comparing base (e9b7d72) to head (e56f623).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2971      +/-   ##
==========================================
- Coverage   83.03%   82.94%   -0.09%     
==========================================
  Files          47       47              
  Lines        4956     4956              
  Branches      583      583              
==========================================
- Hits         4115     4111       -4     
- Misses        698      702       +4     
  Partials      143      143              
Flag Coverage Δ
backend 82.94% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec requested a review from jmgrady March 26, 2024 13:49
Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) March 28, 2024 13:04
@imnasnainaec imnasnainaec merged commit 65f3ba5 into master Mar 28, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the bugfix/stuck-loading branch March 28, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend goal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing browser back button can get stuck on the Loading screen
2 participants