Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated toBeCalled/toBeCalledWith #2950

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 15, 2024

This change is Reviewable

@imnasnainaec imnasnainaec added frontend test maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: S Small sized issue labels Feb 15, 2024
@imnasnainaec imnasnainaec self-assigned this Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.76%. Comparing base (842fecf) to head (69b6996).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2950      +/-   ##
==========================================
- Coverage   72.81%   72.76%   -0.05%     
==========================================
  Files         266      266              
  Lines       10200    10200              
  Branches     1196     1196              
==========================================
- Hits         7427     7422       -5     
- Misses       2424     2428       +4     
- Partials      349      350       +1     
Flag Coverage Δ
backend 82.78% <ø> (-0.11%) ⬇️
frontend 63.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec requested a review from jmgrady March 8, 2024 15:54
Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 9 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 39f719a into master Mar 8, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the to-be-called branch March 8, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: S Small sized issue test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants