Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataEntry > NewEntry] Prevent double submission #2946

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 13, 2024

Resolves #2903


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8677250) 82.90% compared to head (62b554f) 82.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2946      +/-   ##
==========================================
- Coverage   82.90%   82.70%   -0.21%     
==========================================
  Files          47       47              
  Lines        4926     4926              
  Branches      575      575              
==========================================
- Hits         4084     4074      -10     
- Misses        701      708       +7     
- Partials      141      144       +3     
Flag Coverage Δ
backend 82.70% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) February 14, 2024 16:56
@imnasnainaec imnasnainaec merged commit 6ea0515 into master Feb 14, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the data-entry-double-tap branch February 14, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataEntry] Quickly double-press enter causes apparent double-submission
2 participants