Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire unused UI strings from translation file #2905

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 31, 2024

This change is Reviewable

@imnasnainaec imnasnainaec added maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. font/language Size: S Small sized issue labels Jan 31, 2024
@imnasnainaec imnasnainaec self-assigned this Jan 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c9b963) 83.28% compared to head (2ff6acc) 83.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2905      +/-   ##
==========================================
- Coverage   83.28%   83.26%   -0.02%     
==========================================
  Files          47       47              
  Lines        5014     5014              
  Branches      597      597              
==========================================
- Hits         4176     4175       -1     
- Misses        697      698       +1     
  Partials      141      141              
Flag Coverage Δ
backend 83.26% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) February 6, 2024 22:07
@imnasnainaec imnasnainaec merged commit e3363ca into master Feb 6, 2024
16 of 17 checks passed
@imnasnainaec imnasnainaec deleted the translations-cleanup branch February 6, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
font/language maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants