Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MergeDups] Clean up auto-merging of definitions #2898

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 24, 2024

This change is Reviewable

@imnasnainaec imnasnainaec requested a review from jmgrady January 24, 2024 14:37
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (92ac295) 72.82% compared to head (5314dc6) 72.81%.

Files Patch % Lines
...rc/goals/MergeDuplicates/Redux/MergeDupsReducer.ts 63.63% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2898      +/-   ##
==========================================
- Coverage   72.82%   72.81%   -0.02%     
==========================================
  Files         264      264              
  Lines       10016    10019       +3     
  Branches     1183     1184       +1     
==========================================
+ Hits         7294     7295       +1     
- Misses       2378     2379       +1     
- Partials      344      345       +1     
Flag Coverage Δ
backend 83.09% <ø> (ø)
frontend 63.27% <63.63%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit e3d90e6 into master Jan 24, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the merge-in-dup-senses branch January 24, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants