fix(): default filename for blob

[ikosta]

Background

Mozilla FormData.append filename (optional):
The filename reported to the server (a USVString), when a Blob or File is passed as the second parameter. The default filename for Blob objects is "blob". The default filename for File objects is the file's filename.

How the browser works

Basically the filename blob is set by formData.append if blob with no filename is passed.
(I tested this on Safari, Chrome, Firefox, iOS and Android)

// no filename passed
formData = new FormData();

formData.append('json', new Blob(['{"bla":1}'], {type: 'application/json'}));

console.log(formData.entries().next().value[1].name); // will print 'blob'

// empty filename passed
formData = new FormData();

formData.append('json', new Blob(['{"bla":1}'], {type: 'application/json'}), '');

console.log(formData.entries().next().value[1].name); // will print ''

What the plugin does wrong

In the plugin www\helpers.js:456:

result.fileNames.push(entry.value[1].name || 'blob');

And here is the empty filename always overwritten with blob.

How to fix

In the plugin www\helpers.js:456:

result.fileNames.push(entry.value[1].name !== undefined ? entry.value[1].name : 'blob');

Now the filename is only set to blob if it is not defined at all.

Tests

I also added two test to cover all scenarios and fixed the FileMock for that.

[ikosta]

@silkimen what do you think about that fix?

[silkimen]

Hi @ikosta, basically this look good to me, but one of the e2e specs is failing. Maybe you can elaborate what's going wrong here?

[ikosta]

Hi @silkimen, I just pushed a fix in the ponyfills.

[silkimen]

[silkimen]

Thank you @ikosta 🎉