Feature/php7.3 and other improvements #21

mtompset · 2021-03-24T20:21:29Z

Change

Update PHP requirements to 7.3 or higher

Fix

Update PHPUnit to 9.x
Code cleanup with transition to PHP 7.3
Refactor Psr3Yii2Logger::interpolate to only return string

Add

Psr3Yii2Logger::interpolateArray to only return array
Psr3Yii2Logger tests

- return void is the new return null - imported InvalidArguementException - Simplified case statements - Fixed PHPDoc - Did array checking to use new interpolateArray() vs. interpolate()

src/LoggerBase.php

Dockerfile

src/Psr3Yii2Logger.php

tests/Psr3EveryLoggerTest.php

- Removed isArraySupported, since only Psr3Yii2Logger supports arrays - Removed interpolateArray() call in favour of an inline array_merge() - Strongly type interpolateString()

- Move EMERGENCY log level case - remove isArraySupported - replace call to interpolateArray() with array_merge()

forevermatt · 2021-03-25T14:54:56Z

tests/Psr3EveryLoggerTest.php

+            'to' => ['[email protected]', '[email protected]'],
+            'subject' => 'Log message',
+            'formattedMessage' => ['Do not attempt to follow this example.'],


forevermatt · 2021-03-25T14:55:59Z

Dockerfile


 # Make sure apt has current list/updates
+RUN apt-get update -y \
+# Fix timezone stuff from hanging.
+    && echo "Etc/UTC" > /etc/timezone \


Nice change to UTC here 👍

mtompset added 7 commits March 24, 2021 16:07

Update to PHP 7.3 and PHPUnit 9.x

ee6215d

Added interpolateArray() so interpolate() only returns one type

d63989c

Removed unnecessary variable

633e5d6

return void is the new return null. Added import.

77cefe2

return void is the new return null

2faff04

Refactored Psr3Yii2Logger

00daa44

- return void is the new return null - imported InvalidArguementException - Simplified case statements - Fixed PHPDoc - Did array checking to use new interpolateArray() vs. interpolate()

Add Psr3Yii2Logger tests to Psr2EveryLoggerTest

900ebe5

mtompset requested review from forevermatt and briskt March 24, 2021 20:21

mtompset self-assigned this Mar 24, 2021