Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine ID Broker's pull-request template #353

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

forevermatt
Copy link
Contributor

Added

  • Add a place/reminder to paste the YouTrack issue's ID and title in PRs
    • This is easily obtained (with the ID as a link, even) by clicking the "Copy ID and summary to clipboard" icon beside a YouTrack issue's ID link, near the top-left of the page when viewing an issue in a sufficiently-wide browser window, and it seems worth including.

Screenshot 2024-08-19 at 3 20 45 PM

Changed (non-breaking)

  • Separate the PR template "Changed" section for breaking vs. non-breaking
  • Simplify the wording of the checklist to simply say "Tests...", not specifically "Unit tests..."

This is easily obtained (with the ID as a link, even) by clicking the
"Copy ID and summary to clipboard" icon beside a YouTrack issue's ID
link, near the top-left of the page when viewing an issue in a
sufficiently-wide browser window.
@forevermatt forevermatt requested a review from a team August 19, 2024 19:24
Copy link

sonarcloud bot commented Aug 19, 2024

Copy link

@mtompset mtompset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitting Changed between breaking and non-breaking is important. :)

@forevermatt forevermatt merged commit 81131fa into develop Aug 19, 2024
3 checks passed
@forevermatt forevermatt deleted the feature/refine-pull-request-template branch August 19, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants