RpcValue: Cast bools to ints as 0 #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Casting bools to ints never makes sense. The reason I found is in the checkAlarms algorithm, where if you put a boolean as `value`, it could later be interpreted as a bitfield, because of this implicit conversion. It'll still do it now, but at least it won't result in `true` which will stop it from deducing invalid alarms.
|
Hopefully this doesn't break FL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Casting bools to ints never makes sense. The reason I found is in the checkAlarms algorithm, where if you put a boolean as
value, it could later be interpreted as a bitfield, because of this implicit conversion. It'll still do it now, but at least it won't result intruewhich will stop it from deducing invalid alarms.